Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding JCL (Job Control Language) #6249

Merged
merged 5 commits into from
Feb 27, 2023
Merged

Adding JCL (Job Control Language) #6249

merged 5 commits into from
Feb 27, 2023

Conversation

lnlyssg
Copy link
Contributor

@lnlyssg lnlyssg commented Jan 13, 2023

Description

Adding JCL (Job Control Language) - the grammar was already present in https://github.com/spgennard/vscode_cobol/ so I have only added it as a new language

Checklist:

  • I am adding a new language.
    • The extension of the new language is used in hundreds of repositories on GitHub.com.
    • I have included a real-world usage sample for all extensions added in this PR:
      • Sample license(s): JCL isn't exactly unique as there's only so many ways to write it but all samples here are my own
    • I have included a syntax highlighting grammar:
    • I have updated the heuristics to distinguish my language from others using the same extension.

@lnlyssg lnlyssg requested a review from a team as a code owner January 13, 2023 21:31
lildude
lildude reviewed Feb 17, 2023
View reviewed changes
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, just noticed you've not provided a colour. This means a boring dull grey will be used. Do you want a colour or are you happy with the boring grey?

@lnlyssg
Copy link
Contributor Author

lnlyssg commented Feb 24, 2023 •
edited by lildude
Loading

Whoops, just noticed you've not provided a colour. This means a boring dull grey will be used. Do you want a colour or are you happy with the boring grey?

Oops, I missed this (and the reply). There's no "official" colour as such so I've gone with #d90e09

@lildude lildude merged commit b80b69c into github-linguist:master Feb 27, 2023
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lildude lildude lildude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lnlyssg @lildude